Opened 3 years ago

Closed 3 years ago

#21 closed defect (fixed)

Minimize the memory consumption when uploading images

Reported by: jokalli2 Owned by: jokalli2
Priority: major Milestone: 0.8
Component: Symbian Version: .5
Keywords: Cc:

Description

Image upload is very memory consuming because of the image data is sent inside XML as base64 encoded. We should make sure that no extra memory allocations are made and that buffers are preallocated to sensible values, so that too large allocations cannot happen.

Some kind of reproducible test case would be nice. I will ask Peter about that.

Change History (3)

comment:1 Changed 3 years ago by petertennekes

Let's have a look at this when I return for the testcase. Maybe we should also see if we can have some check to see if the image is not to big and if it is ask to user resize or skip the upload,

comment:2 Changed 3 years ago by jokalli2

The implementation is now complete, but there have been reports that uploading multiple images fail. This seems to be not related to the memory consumption. Let's investigate that as well.

comment:3 Changed 3 years ago by tmar

  • Resolution set to fixed
  • Status changed from new to closed

Commits r201 and r202 change image uploads to use a single preallocated buffer, and should help with this.

I haven't tested on s60 or the more memory-constrained devices, but lacking a 'testing' status, I'll mark this as fixed. Reopen if it's still an issue.

Note: See TracTickets for help on using tickets.